Skip to content

chore: remove or move obsolete dockerfiles into 'obsolete' subdirectory #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kojiromike opened this issue May 1, 2025 · 2 comments

Comments

@kojiromike
Copy link
Contributor

After working on some improvements to the Dockerfiles, I realized that OpenEMR is surely not supporting every old version. 5.0.0 and 5.0.1 don't build. (Pinning certbot might fix it, but do you want to?) In fact, you're probably only supporting the ones that are targeted by the workflows in .github/workflows/build-*.yml. I think it would be easier to navigate and understand this repo if these obsolete directories were removed or clearly marked as such.

My suggestion would be to remove the obsolete subdirectories from docker/ entirely, and leave them to git history. But if that is not in line with the project's way of doing things, would you be amenable to moving them into a different directory structure, such as docker/obsolete/?

Among other things, this would make it easier to target the ones that are maintained with scripts and AI.

@jesdynf
Copy link
Collaborator

jesdynf commented May 4, 2025

Generally the mostest recent one is the developer branch, and the one before it is the one that's currently released.

I don't think we should bin them to git history if the docker images are still in the docker hub -- we should never be in a position where we're showing people artifacts we can't easily build -- but nothing depends on the location of these files in the devops repo, we could put them in an "obsolete" box just fine, I think. @bradymiller ?

@bradymiller
Copy link
Member

Placing them in docker/obsolete sounds fine (we would need to update the links to the dockerbuild files in the dockerhub listings (for documentation purposes), which would be easy to do). Sounds like one of the advantages to this is could ignore the obsolete stuff for the shellcheck stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants