Skip to content

Commit f4c8287

Browse files
committed
fixup! 🏗️(project) migrate to pydantic v2 and switch tests to polyfactory
1 parent 16c97de commit f4c8287

File tree

9 files changed

+6
-15
lines changed

9 files changed

+6
-15
lines changed

src/ralph/conf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import io
44
from enum import Enum
55
from pathlib import Path
6-
from typing import List, Literal, Optional, Tuple, Union
6+
from typing import List, Optional, Tuple, Union
77

88
from pydantic import (
99
AfterValidator,

src/ralph/models/edx/bookmark/fields/events.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import sys
44
from typing import Optional
5-
from typing_extensions import Annotated
65

76
from pydantic import StringConstraints
7+
from typing_extensions import Annotated
88

99
from ...base import AbstractBaseEventField
1010

src/ralph/models/edx/certificate/fields/events.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
"""Cohort event field definition."""
22

33
import sys
4-
from typing_extensions import Annotated
54
from uuid import UUID
65

76
from pydantic import AnyHttpUrl, StringConstraints
7+
from typing_extensions import Annotated
88

99
from ...base import AbstractBaseEventField
1010

src/ralph/models/edx/notes/fields/events.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import sys
44
from typing import Dict, List
5-
from typing_extensions import Annotated
65

76
from pydantic import StringConstraints
7+
from typing_extensions import Annotated
88

99
from ...base import AbstractBaseEventField
1010

src/ralph/models/edx/teams_related/fields/events.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import sys
44
from typing import List, Union
5-
from typing_extensions import Annotated
65

76
from pydantic import StringConstraints, validator
7+
from typing_extensions import Annotated
88

99
from ...base import AbstractBaseEventField
1010

tests/backends/data/test_async_lrs.py

-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ def test_backends_data_async_lrs_default_instantiation(monkeypatch, fs, lrs_back
4848
assert backend.query_class == LRSStatementsQuery
4949
assert backend.base_url == parse_obj_as(AnyHttpUrl, "http://0.0.0.0:8100")
5050
assert backend.auth == ("ralph", "secret")
51-
print(f"{backend.settings.HEADERS =}")
5251
assert backend.settings.HEADERS == LRSHeaders()
5352
assert backend.settings.LOCALE_ENCODING == "utf8"
5453
assert backend.settings.READ_CHUNK_SIZE == 500

tests/backends/data/test_base.py

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import asyncio
44
import logging
5-
import re
65
from typing import Any, Dict, Generic, TypeVar, Union
76

87
import pytest

tests/models/edx/notes/test_events.py

-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
"""Tests for notes models event fields."""
22

33
import json
4-
import sys
5-
from typing import List
64

75
import pytest
86
from pydantic.error_wrappers import ValidationError
@@ -15,11 +13,6 @@
1513

1614
from tests.factories import mock_instance
1715

18-
if sys.version_info >= (3, 8):
19-
from typing import Literal
20-
else:
21-
from typing_extensions import Literal
22-
2316

2417
def test_models_edx_notes_event_field_with_valid_field():
2518
"""Test that a valid `NotesEventField` does not raise a

tests/models/edx/notes/test_statements.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def test_models_edx_ui_edx_course_student_notes_searched_with_valid_statement():
7575
assert statement.name == "edx.course.student_notes.searched"
7676

7777

78-
def test_models_edx_ui_edx_course_student_notes_notes_page_viewed_with_valid_statement():
78+
def test_models_edx_ui_edx_course_student_notes_notes_page_viewed_with_valid_statement(): # noqa: E501
7979
"""Test that a `edx.course.student_notes.notes_page_viewed` statement has
8080
the expected `event_type` and `name`.
8181
"""

0 commit comments

Comments
 (0)