From ec46ef8c32bdecb1f427c99b8afa72517187a631 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastian=20Echterh=C3=B6lter?=
 <bastian.echterhoelter@sap.com>
Date: Thu, 23 Jan 2025 16:53:34 +0100
Subject: [PATCH] fix: Extension Finalization

The metadataGoTemplate was not properly rendered in case of finalization leading to misbehavior on finalization
---
 pkg/subroutines/extensions.go | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/pkg/subroutines/extensions.go b/pkg/subroutines/extensions.go
index ae90e56..2b89311 100644
--- a/pkg/subroutines/extensions.go
+++ b/pkg/subroutines/extensions.go
@@ -13,6 +13,7 @@ import (
 	"github.com/kcp-dev/logicalcluster/v3"
 	"github.com/openmfp/golang-commons/controller/lifecycle"
 	"github.com/openmfp/golang-commons/errors"
+	"github.com/openmfp/golang-commons/logger"
 	v1 "k8s.io/api/core/v1"
 	kerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -144,6 +145,7 @@ func RenderExtensionSpec(ctx context.Context, keyValues map[string]any, account
 }
 
 func (e *ExtensionSubroutine) Finalize(ctx context.Context, instance lifecycle.RuntimeObject) (ctrl.Result, errors.OperatorError) {
+	log := logger.LoadLoggerFromContext(ctx)
 	account := instance.(*v1alpha1.Account)
 
 	lookupNamespace := account.GetNamespace()
@@ -157,11 +159,31 @@ func (e *ExtensionSubroutine) Finalize(ctx context.Context, instance lifecycle.R
 		us := unstructured.Unstructured{}
 		us.SetGroupVersionKind(extension.GroupVersionKind())
 
-		us.SetName(strings.ToLower(extension.Kind))
+		if len(extension.MetadataGoTemplate.Raw) > 0 {
+			var metadataKeyValues map[string]any
+			err := json.NewDecoder(bytes.NewReader(extension.MetadataGoTemplate.Raw)).Decode(&metadataKeyValues)
+			if err != nil {
+				return ctrl.Result{}, errors.NewOperatorError(err, true, false)
+			}
+			err = RenderExtensionSpec(ctx, metadataKeyValues, account, &us, []string{"metadata"})
+			if err != nil {
+				return ctrl.Result{}, errors.NewOperatorError(err, true, false)
+			}
+		}
+
+		if us.GetName() == "" {
+			us.SetName(strings.ToLower(extension.Kind))
+		}
 		if namespaced, err := e.client.IsObjectNamespaced(&us); err == nil && namespaced {
 			us.SetNamespace(*account.Status.Namespace)
 		}
 
+		log.Info().
+			Str("name", us.GetName()).
+			Str("kind", us.GetKind()).
+			Str("namespace", us.GetNamespace()).
+			Msg("Deleting extension")
+
 		err := e.client.Delete(ctx, &us)
 		if kerrors.IsNotFound(err) {
 			continue