Skip to content

Commit

Permalink
fix (deployment): run portal container as root
Browse files Browse the repository at this point in the history
  • Loading branch information
akafazov committed Jan 7, 2025
1 parent 606d1ca commit 0ba0716
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
6 changes: 5 additions & 1 deletion charts/portal/templates/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ spec:
app: {{ include "common.entity.name" . }}
spec:
{{- include "common.imagePullSecret" . | indent 6}}
{{ include "common.container.securityContext" . | nindent 6 }}
securityContext:
readOnlyRootFilesystem: true
runAsNonRoot: false
seccompProfile:
type: RuntimeDefault
containers:
- name: {{ include "common.entity.name" . }}
image: {{ .Values.image.name }}:{{ .Chart.AppVersion }}
Expand Down
2 changes: 1 addition & 1 deletion charts/portal/tests/__snapshot__/deploy_test.yaml.snap
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ matches the snapshot:
- name: github
securityContext:
readOnlyRootFilesystem: true
runAsNonRoot: true
runAsNonRoot: false
seccompProfile:
type: RuntimeDefault
4 changes: 2 additions & 2 deletions charts/portal/tests/__snapshot__/istio_test.yaml.snap
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ matches the snapshot:
- name: github
securityContext:
readOnlyRootFilesystem: true
runAsNonRoot: true
runAsNonRoot: false
seccompProfile:
type: RuntimeDefault
2: |
Expand Down Expand Up @@ -240,7 +240,7 @@ matches the snapshot with istio disabled:
- name: github
securityContext:
readOnlyRootFilesystem: true
runAsNonRoot: true
runAsNonRoot: false
seccompProfile:
type: RuntimeDefault
2: |
Expand Down
1 change: 1 addition & 0 deletions local-setup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ upgrade the Helm releases to their latest chart version based on semver ranges.
## Prerequisites

- [Docker](https://www.docker.com) or [podman](https://podman.io): install either docker or podman in order to run the kind cluster
Resources: configure at least 10GB of memory for docker
- [Kind](https://kind.sigs.k8s.io/): In order to have a local kubernetes cluster you can use kind. Kind Installation: [Kind Quick Start](https://kind.sigs.k8s.io/docs/user/quick-start/)
On macOS using Homebrew:
```sh
Expand Down

0 comments on commit 0ba0716

Please sign in to comment.