Skip to content

Commit

Permalink
fix: update health probe paths and configurations in deployment tests
Browse files Browse the repository at this point in the history
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
  • Loading branch information
akafazov committed Nov 25, 2024
1 parent 7af46aa commit ed77a43
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ operator match the snapshot:
livenessProbe:
failureThreshold: 1
httpGet:
path: /healthz
path: /readyz
port: 8081
periodSeconds: 10
name: manager
Expand All @@ -100,7 +100,7 @@ operator match the snapshot:
httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 45
initialDelaySeconds: 5
periodSeconds: 10
resources:
limits:
Expand All @@ -115,7 +115,7 @@ operator match the snapshot:
startupProbe:
failureThreshold: 30
httpGet:
path: /healthz
path: /readyz
port: 8081
periodSeconds: 10
serviceAccountName: RELEASE-NAME-extension-manager-operator
Expand Down
8 changes: 8 additions & 0 deletions charts/extension-manager-operator/tests/deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,19 @@ tests:
set:
istio:
enabled: true
health:
port: 8081
liveness:
path: /readyz
metrics:
port: 8080
- it: deployment with metrics probes
template: deployment.yaml
set:
health:
port: 8081
liveness:
path: /healthz
metrics:
port: 8082
asserts:
Expand Down
20 changes: 20 additions & 0 deletions charts/extension-manager-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,28 @@ imagePullSecret: "github"

# The health probe configuration
## @param health.port The port for the health probe
## @param health.periodSeconds The period in seconds for performing the probe
## @param health.readiness.path The path for the readiness probe
## @param health.readiness.initialDelaySeconds The initial delay in seconds before starting the readiness probe
## @param health.readiness.periodSeconds The period in seconds for performing the readiness probe
## @param health.liveness.path The path for the liveness probe
## @param health.liveness.failureThreshold The failure threshold for the liveness probe
## @param health.startup.path The path for the startup probe
## @param health.startup.failureThreshold The failure threshold for the startup probe
health:
port: 8081
periodSeconds: 10
readiness:
path: "/readyz"
initialDelaySeconds: 5
periodSeconds: 10
liveness:
path: "/healthz"
failureThreshold: 1
startup:
path: "/readyz"
failureThreshold: 30

Check failure on line 35 in charts/extension-manager-operator/values.yaml

View workflow job for this annotation

GitHub Actions / pipeline / testChart / lint

35:1 [trailing-spaces] trailing spaces

# The metrics configuration
## @param metrics.port The port for the metrics
Expand Down

0 comments on commit ed77a43

Please sign in to comment.