Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to specify virtualworkspaceurl via environment #2

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat: allow to specify virtualworkspaceurl via environment #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82542b1
feat: allow to specify virtualworkspaceurl
nexus49 Oct 25, 2024
dc93c0c
chore: bump chart version
nexus49 Oct 25, 2024
fb3fd59
fix: fixed env variable name
nexus49 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/account-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: account-operator
description: A Helm chart for Kubernetes
type: application
version: 0.1.17
version: 0.1.18
appVersion: "0.60.0"
dependencies:
- name: account-operator-crds
Expand Down
2 changes: 2 additions & 0 deletions charts/account-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ spec:
env:
- name: KCP_ENABLED
value: "{{ .Values.kcp.enabled }}"
- name: KCP_VIRTUAL_WORKSPACE_URL
value: "{{ .Values.kcp.virtualWorkspaceUrl }}"
{{- if .Values.kubeconfigSecret }}
- name: KUBECONFIG
value: /api-kubeconfig/kubeconfig
Expand Down
4 changes: 4 additions & 0 deletions charts/account-operator/tests/__snapshot__/deployment_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ operator match the snapshot:
env:
- name: KCP_ENABLED
value: "false"
- name: KCP_VIRTUAL_WORKSPACE_URL
value: ""
image: ghcr.io/openmfp/account-operator:0.0.0
livenessProbe:
httpGet:
Expand Down Expand Up @@ -235,6 +237,8 @@ operator match the snapshot (with kubeconfigSecret):
env:
- name: KCP_ENABLED
value: "false"
- name: KCP_VIRTUAL_WORKSPACE_URL
value: ""
- name: KUBECONFIG
value: /api-kubeconfig/kubeconfig
image: ghcr.io/openmfp/account-operator:0.0.0
Expand Down
1 change: 1 addition & 0 deletions charts/account-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ deployment:

kcp:
enabled: false
virtualWorkspaceUrl: ""

kubeconfigSecret: ""
Loading