Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (move): charts from private to public #26

Merged
merged 84 commits into from
Dec 3, 2024
Merged

chore (move): charts from private to public #26

merged 84 commits into from
Dec 3, 2024

Conversation

akafazov
Copy link
Member

@akafazov akafazov commented Nov 22, 2024 •
edited
Loading

Changes:

  • moving charts extension-manager-operator and extension-manager-operator-crds
  • fixing vulnerability issues: added readOnlyRootFilesystem to POD securityContext
  • open-source preparation:
    • README.md file
    • annotate values.yaml
    • apply common patterns: extraAnnotations
  • develop generic value lookup with overwrite, global mechanic
  • refactor templates and documentation

refers to #20

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@akafazov
fix: update extension-content-operator references to extension-manage…
d63aaaf 
…r-operator in deployment test snapshot
@akafazov
bump versions
5723bd8
@akafazov
fix: update extension-manager-operator dependencies to version 0.1.3 …
142fc30 
…and change repository paths
@akafazov
fix: enable read-only root filesystem for manager container in deploy…
913275c 
…ment.yaml
@akafazov
fix: enable read-only root filesystem for account-operator manager co…
9952f93 
…ntainer in deployment.yaml
@akafazov
fix: enable read-only root filesystem in deployment test snapshots fo…
ee29b95 
…r account and extension manager operators
@akafazov
fix: bump account-operator and portal chart versions to 0.4.17 and 0.…
936eb3a 
…69.92 respectively
@akafazov
fix: update .gitignore to exclude bin directory and add kube-lint set…
ff9b496 
…up task in Taskfile.yaml
@akafazov
trigger ci
92c1f3d
@akafazov
Add chart READMEs
dae31ad
@akafazov
feat (values): annotate parameters
245cb8f
@akafazov
fix: update common chart version to 0.1.5 and adjust related dependen…
091f4f7 
…cies
@akafazov
fix: update workflow to skip vulnerability scan in pipeline-chart.yml
d60948e
@akafazov akafazov requested a review from nexus49 November 22, 2024 14:51
@akafazov
signoff commit
2a8ced8 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
fix: update workflow to use the main branch for pipeline-chart.yml
3ab471c 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
nexus49
nexus49 requested changes Nov 25, 2024
View reviewed changes
@akafazov
migrate _deploymentHelpers and use common.security in template
de0971f 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
fix: update health probe configurations and remove unnecessary namesp…
7af46aa 
…ace resource

On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
fix: update health probe paths and configurations in deployment tests
ed77a43 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
fix: add common termination grace period to deployment templates
076cd6e 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: add support for customizable deployment template labels
0e9cecb 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: add support for customizable annotations in deployment templates
1490183 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: add support for customizable image pull policy in deployment te…
d7af046 
…mplates

On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
fix: remove namespace from deployment metadata in templates
6883e75 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: update portal release name in templates and tests
a0166b7 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: add optional image pull secret configuration in templates and t…
156528e 
…ests

On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
akafazov and others added 6 commits November 28, 2024 09:52
@akafazov
update helm-docs
7f83a7a 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: refactor Istio configuration and update security context handling
f739b94 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
Merge remote-tracking branch 'origin/main' into chore/move-charts
988fd0e
@akafazov
chore: update version numbers for openmfp and portal charts
fedff7b 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat: enable external secrets and refactor deployment configuration
b856f4e 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@TobiasOetzel
Add 4 layered lookup
5d813dc 
also: edited taskfile to update subcharts
also: included test chart into the test/update commands
also: increased test coverage for the overwriting mechanics
also: deleted the cert manager template, since it was only used in testing
also: added a helmignore to avoid recursive zips
tobias-oetzel and others added 16 commits November 28, 2024 16:36
@tobias-oetzel
Merge branch 'main' into chore/move-charts
ed47971
@TobiasOetzel
add generated docs
57eca3f
@tobias-oetzel
Merge branch 'main' into chore/move-charts
120f95d
@TobiasOetzel
update readmes
8026042
@TobiasOetzel
update readmes
42e6d44
@TobiasOetzel
update readme
a6f1a33
@TobiasOetzel
update readme
750287a
@TobiasOetzel
update readmes
90b7500
@TobiasOetzel
update readmes
52c2b1e
@TobiasOetzel
Merge remote-tracking branch 'origin/chore/move-charts' into chore/mo…
5d8e447 
…ve-charts
@TobiasOetzel
version bump
8837f23
@TobiasOetzel
update common docs
038361f
@TobiasOetzel
getting rid of double docs tables
35c0892
@tobias-oetzel
Merge branch 'main' into chore/move-charts
4fee5ea
@akafazov
Merge remote-tracking branch 'origin/main' into chore/move-charts
2e1e0bc 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat(charts): update app versions and add new portal chart
f7b7f72 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
nexus49
nexus49 requested changes Dec 3, 2024
View reviewed changes
charts/common/templates/_getKeyLookup.tpl Outdated
Function: common.getKeyValue
Description:
Retrieves a value from values.yaml by checking keys in this order:
1. Override key, 2. Global key, 3. Default key. Returns an empty string if none exist.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic has 4 steps right? we need to update this doc

nexus49 and others added 3 commits December 3, 2024 11:06
@nexus49
Merge branch 'main' into chore/move-charts
d62c340
@akafazov
update docs of getKeyLookup.tpl
0badde6 
On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov
feat(charts): bump chart versions for example-content, openmfp, and p…
67d223a 
…ortal

On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
@akafazov akafazov merged commit ed3c9b5 into main Dec 3, 2024
18 checks passed
@akafazov akafazov deleted the chore/move-charts branch December 3, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexus49 nexus49 nexus49 approved these changes

@tobias-oetzel tobias-oetzel tobias-oetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akafazov @nexus49 @tobias-oetzel @TobiasOetzel