fix (validation): deployment and ext access toggle

charts/extension-manager-operator/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: extension-manager-operator
 description: A Helm chart for extension-manager-operator which manages resources like ContentConfigurations and exposes REST `/validate` endpoint
 type: application
-version: 0.22.96
+version: 0.23.0
 appVersion: "0.113.0"
 dependencies:
   - name: extension-manager-operator-crds

charts/extension-manager-operator/README.md

@@ -17,7 +17,7 @@ A Helm chart for extension-manager-operator which manages resources like Content
 | crds.enabled | bool | `true` |  |
 | image.name | string | `"ghcr.io/openmfp/extension-manager-operator"` |  |
 | image.tag | string | `"0.22.48"` |  |
-| validationServer.enabled | bool | `false` | enable the validation server |
+| istio.enabled | bool | `false` | enable Istio VirtualService |
 | validationServer.host | string | `"*"` | host for the validation VirtualService |
 | validationServer.port | int | `8088` | port for the validation server |
 

charts/extension-manager-operator/templates/deployment.yaml

@@ -38,7 +38,6 @@ spec:
           {{- include "common.PortsMetricsHealth" . | nindent 10 -}}
           {{- include "common.operatorHealthAndReadyness" . | nindent 10 -}}
           {{- include "common.resources" . | nindent 10 }}
-        {{- if .Values.validationServer.enabled }}
         - args:
           - server
           image: {{ .Values.image.name }}:{{ .Chart.AppVersion }}
@@ -49,5 +48,4 @@ spec:
           - containerPort: {{ .Values.validationServer.port }}
           {{- include "common.PortsMetricsHealth" . | nindent 10 -}}
           {{ include "common.operatorHealthAndReadyness" . | nindent 10 }}
-        {{- end }}
       terminationGracePeriodSeconds: {{ include "common.terminationGracePeriodSeconds" .}}

charts/extension-manager-operator/templates/service.yaml

@@ -1,4 +1,3 @@
-{{- if .Values.validationServer.enabled }}
 apiVersion: v1
 kind: Service
 metadata:
@@ -13,4 +12,3 @@ spec:
     - protocol: TCP
       port: {{ .Values.validationServer.port }}
       targetPort: {{ .Values.validationServer.port }}
-{{- end }}

charts/extension-manager-operator/templates/virtual-service.yaml

@@ -1,5 +1,4 @@
 {{- if eq (include "common.getKeyValue" (dict "Values" .Values "key" "istio.enabled")) "true" -}}
-{{- if .Values.validationServer.enabled }}
 apiVersion: networking.istio.io/v1alpha3
 kind: VirtualService
 metadata:
@@ -20,4 +19,3 @@ spec:
             port:
               number: {{ .Values.validationServer.port }}
 {{- end }}
-{{- end }}

charts/extension-manager-operator/tests/__snapshot__/deployment_test.yaml.snap

@@ -123,6 +123,42 @@ operator match the snapshot:
                   path: /readyz
                   port: 8081
                 periodSeconds: 10
+            - args:
+                - server
+              image: ghcr.io/openmfp/extension-manager-operator:1.0.0
+              imagePullPolicy: Always
+              livenessProbe:
+                failureThreshold: 1
+                httpGet:
+                  path: /readyz
+                  port: 8081
+                periodSeconds: 10
+              name: server
+              ports:
+                - containerPort: 8088
+                - containerPort: 8080
+                  name: metrics
+                  protocol: TCP
+                - containerPort: 8081
+                  name: health-port
+                  protocol: TCP
+              readinessProbe:
+                httpGet:
+                  path: /readyz
+                  port: 8081
+                initialDelaySeconds: 5
+                periodSeconds: 10
+              securityContext:
+                readOnlyRootFilesystem: true
+                runAsNonRoot: true
+                seccompProfile:
+                  type: RuntimeDefault
+              startupProbe:
+                failureThreshold: 30
+                httpGet:
+                  path: /readyz
+                  port: 8081
+                periodSeconds: 10
           securityContext:
             runAsNonRoot: true
             seccompProfile:

charts/extension-manager-operator/values.yaml

@@ -15,9 +15,11 @@ crds:
 commonAnnotations: {}
 
 validationServer:
-  # -- enable the validation server
-  enabled: false
   # -- port for the validation server
   port: 8088
   # -- host for the validation VirtualService
   host: "*"
+
+istio:
+  # -- enable Istio VirtualService
+  enabled: false