feat (chart): add infra #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP angel.kafazov@sap.com Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
nexus49
requested changes
Dec 3, 2024
| @@ -0,0 +1,16 @@ | |||
| {{- if (.Values.auth).host -}} | |||
There was a problem hiding this comment.
can you also add a keycloak.enabled toggle here?
There was a problem hiding this comment.
or maybe rename the list to .Values.keycloak.hosts.
.Values.host is quite generic. For consistency sake having the keycloak.enabled toggle would still be good i think
charts/infra/templates/store.yaml
Outdated
| @@ -0,0 +1,11 @@ | |||
| {{- range .Values.stores }} | |||
There was a problem hiding this comment.
same here, lets have a .Values.fga.stores list and also a .Values.fga.enabled toggle
| @@ -0,0 +1,30 @@ | |||
| {{- if .Values.clusterRole.enabled -}} | |||
There was a problem hiding this comment.
rename toggle to be
.Values.rbac.clusterReader.enabled
On-behalf-of: @SAP angel.kafazov@sap.com Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #24