(fix) Remove non-functional view links from stock metrics cards (#296)

Removes the `View ->` links from the metrics cards on the stock management dashboard. These links don't currently navigate anywhere. Removing them clears up potential confusion for users.

Author: denniskigen

src/core/components/card/metrics-card-component.tsx

@@ -2,10 +2,8 @@ import React from 'react';
 import dayjs from 'dayjs';
 import isSameOrBefore from 'dayjs/plugin/isSameOrBefore';
 import { useTranslation } from 'react-i18next';
-import { ArrowRight } from '@carbon/react/icons';
 import { isEmpty } from 'lodash-es';
 import { Tile } from '@carbon/react';
-import { ConfigurableLink } from '@openmrs/esm-framework';
 import styles from './metrics-card.scss';
 
 dayjs.extend(isSameOrBefore);
@@ -15,7 +13,6 @@ interface MetricsCardProps {
   value: number;
   headerLabel: string;
   children?: React.ReactNode;
-  view: string;
   count?: { expiry6months: Array<any> };
   outOfStockCount?: { itemsBelowMin: Array<any>; itemsAboveMax: Array<any> };
   disposedCount?: { expired: Array<any>; poorQuality: Array<any> };
@@ -25,7 +22,6 @@ const MetricsCard: React.FC<MetricsCardProps> = ({
   value,
   headerLabel,
   children,
-  view,
   count,
   outOfStockCount,
   disposedCount,
@@ -39,12 +35,6 @@ const MetricsCard: React.FC<MetricsCardProps> = ({
           <label className={styles.headerLabel}>{headerLabel}</label>
           {children}
         </div>
-        {view && (
-          <ConfigurableLink className={styles.link} to={`\${openmrsSpaBase}/stock-management/orders`}>
-            <span>{t('view', 'View')}</span>
-            <ArrowRight size={16} />
-          </ConfigurableLink>
-        )}
       </div>
       <div className={styles.metricsGrid}>
         <div>

src/stock-home/stock-home-metrics.component.tsx

@@ -56,7 +56,6 @@ const StockManagementMetrics: React.FC = (filter: StockOperationFilter) => {
         headerLabel={t('expiringStock', 'Expiring stock')}
         label={t('expiringStock', 'Expiring stock')}
         value={filteredData?.length || 0}
-        view="items"
       />
       <MetricsCard
         label={t('outOfStock', 'Out of stock')}
@@ -66,7 +65,6 @@ const StockManagementMetrics: React.FC = (filter: StockOperationFilter) => {
           itemsAboveMax: [],
         }}
         value={allStocks?.length}
-        view="items"
       />
       <MetricsCard
         disposedCount={{
@@ -76,7 +74,6 @@ const StockManagementMetrics: React.FC = (filter: StockOperationFilter) => {
         headerLabel={t('disposedStock', 'Disposed stock')}
         label={t('disposedStock', 'Disposed stock')}
         value={items?.length || 0}
-        view="items"
       />
     </div>
   );

translations/en.json

@@ -339,7 +339,6 @@
   "updatePackingUnitTitle": "Package Unit",
   "uploadStockItems": "Upload stock items",
   "user": "User",
-  "view": "View",
   "viewAll": "View All",
   "whoIsThePreferredVendor": "Who is the preferred vendor?",
   "yes": "Yes"