Skip to content

(feat) O3-4548: Show expiry date on stock operation #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ogollah
Copy link
Contributor

@Ogollah Ogollah commented Mar 19, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

What does this PR do?

  • Show/render Expiry date when doing stock operation that requires expiry date

Screenshots

Screencast.from.18-03-2025.11.15.31.ALASIRI.webm

2025-03-25 at 09 54 16

Related Issue

Other

@makombe makombe requested review from jabahum and makombe March 19, 2025 13:57
Copy link
Contributor

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ogollah I hope we are also showing the expiry date on the drop down selection as well and not only when you have selected. With that it will help avoid the back and forth

Copy link
Contributor

@makombe makombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ogollah

@@ -5,6 +5,7 @@ import { useStockItemBatchNos } from './batch-no-selector.resource';
import { StockBatchDTO } from '../../core/api/types/stockItem/StockBatchDTO';
import { useStockItemBatchInformationHook } from '../../stock-items/add-stock-item/batch-information/batch-information.resource';
import { useTranslation } from 'react-i18next';
import { formatForDatePicker } from '../../constants';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we have custom formateDatePicker. We need to start aligning with the community standard date picker formats

@makombe makombe merged commit 99eb9fa into openmrs:main Mar 25, 2025
5 checks passed
makombe pushed a commit to makombe/esm-ugandaemr-stock-management that referenced this pull request Mar 25, 2025
* Show expiration date on stock operation

* Add tooltip to show expiration date on hover

* align qty and expiry
makombe added a commit to palladiumkenya/openmrs-esm-stock-management that referenced this pull request Mar 25, 2025
(feat) O3-4548: Show expiry date on stock operation (openmrs#261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants