-
Notifications
You must be signed in to change notification settings - Fork 27
(chore) Bump Angular to v18 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this, @donaldkibet! I've left some suggestions for package version bumps.
projects/ngx-formentry/package.json
Outdated
"@ng-select/ng-select": "^12.0.7", | ||
"@ngx-translate/core": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for these two deps.
This upgrade will necessitate a corresponding version upgrade for the Angular file uploader, a direct dependency of this library, as well as a Node version bump (to |
@donaldkibet I've just released v18 of ngx-file-uploader with Angular 18 support https://github.com/openmrs/openmrs-ngx-file-uploader/releases/tag/v18.0.0. All you'd need to do is bump the dependency to the latest available version: |
Well, we're going to need to upgrade anyway. Support for 18 drops in May. |
cc @denniskigen |
c846801
to
d06942d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @donaldkibet!
@donaldkibet Any chance you've got an update in the works to get esm-form-entry-app onto Angular 18? If you do, but don't have the bandwidth to do it, let me know. |
Requirements
Summary
Bump to version 18
Screenshots
Related Issue
Other