Fix env file not being copied in V3 (#432)

* fix env file not copied to the server bundle

* add e2e test

* Create pretty-spies-rush.md

Author: conico974

.changeset/pretty-spies-rush.md

@@ -0,0 +1,5 @@
+---
+"open-next": patch
+---
+
+Fix env file not being copied in V3

examples/app-pages-router/.env

@@ -0,0 +1 @@
+SOME_ENV_VAR=foo

examples/app-pages-router/app/ssr/page.tsx

@@ -18,6 +18,7 @@ export default async function SSR() {
     <div>
       <h1>Time: {time}</h1>
       <div> {headerList.get("host")}</div>
+      <div>Env: {process.env.SOME_ENV_VAR}</div>
     </div>
   );
 }

examples/pages-router/.env.production

@@ -0,0 +1 @@
+SOME_PROD_VAR=bar

examples/pages-router/src/pages/ssr/index.tsx

@@ -4,17 +4,20 @@ export async function getServerSideProps() {
   return {
     props: {
       time: new Date().toISOString(),
+      envVar: process.env.SOME_PROD_VAR,
     },
   };
 }
 
 export default function Page({
   time,
+  envVar,
 }: InferGetServerSidePropsType<typeof getServerSideProps>) {
   return (
     <>
       <h1>SSR</h1>
       <div className="flex">Time: {time}</div>
+      <div>Env: {envVar}</div>
     </>
   );
 }

packages/open-next/src/build/createServerBundle.ts

@@ -21,6 +21,7 @@ import { generateEdgeBundle } from "./edge/createEdgeBundle.js";
 import type { BuildOptions } from "./helper.js";
 import {
   compareSemver,
+  copyEnvFile,
   copyOpenNextConfig,
   esbuildAsync,
   traverseFiles,
@@ -176,6 +177,9 @@ async function generateBundle(
     path.join(outputPath, packagePath),
   );
 
+  //Copy env files
+  copyEnvFile(appBuildOutputPath, packagePath, outputPath);
+
   // Copy all necessary traced files
   copyTracedFiles(
     appBuildOutputPath,

packages/open-next/src/build/helper.ts

@@ -254,3 +254,20 @@ export function copyOpenNextConfig(
     path.join(outputPath, "open-next.config.mjs"),
   );
 }
+
+export function copyEnvFile(
+  appPath: string,
+  packagePath: string,
+  outputPath: string,
+) {
+  const baseAppPath = path.join(appPath, ".next/standalone", packagePath);
+  const baseOutputPath = path.join(outputPath, packagePath);
+  const envPath = path.join(baseAppPath, ".env");
+  if (fs.existsSync(envPath)) {
+    fs.copyFileSync(envPath, path.join(baseOutputPath, ".env"));
+  }
+  const envProdPath = path.join(baseAppPath, ".env.production");
+  if (fs.existsSync(envProdPath)) {
+    fs.copyFileSync(envProdPath, path.join(baseOutputPath, ".env.production"));
+  }
+}

packages/tests-e2e/tests/appPagesRouter/ssr.test.ts

@@ -26,3 +26,9 @@ test("Server Side Render", async ({ page }) => {
     await wait(250);
   }
 });
+
+test("Server Side Render with env", async ({ page }) => {
+  await page.goto("/ssr");
+  let el = page.getByText("Env:");
+  expect(await el.textContent()).toEqual("Env: foo");
+});

packages/tests-e2e/tests/pagesRouter/ssr.test.ts

@@ -26,3 +26,9 @@ test("Server Side Render", async ({ page }) => {
     await wait(250);
   }
 });
+
+test("Server Side Render with env", async ({ page }) => {
+  await page.goto("/ssr/");
+  let el = page.getByText("Env:");
+  expect(await el.textContent()).toEqual("Env: bar");
+});