Skip to content

Fix: await cache set #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Fix: await cache set #446

merged 7 commits into from
Jun 19, 2024

Conversation

conico974
Copy link
Contributor

Don't know how this one could have gone undetected, but set is not properly awaited.
I'll test this and merge this tomorrow, probably do a release as well.
Maybe the latest PR was not even entirely necessary

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 0a5d09c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 11:32am

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I wonder if there's a lint that trigger Github to warn like it's warning the missing else clause below. At minimum, it would bring our attention to subtle things like this.

@conico974
Copy link
Contributor Author

Good catch. I wonder if there's a lint that trigger Github to warn like it's warning the missing else clause below. At minimum, it would bring our attention to subtle things like this.

Yeah there is a bunch of them, i thought they was already included to be honest. I'll add them to the eslint config and fix any error that we found here

@conico974 conico974 merged commit 8f1d2b4 into opennextjs:main Jun 19, 2024
3 checks passed
@conico974 conico974 deleted the fix/await-cache branch October 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants