-
Notifications
You must be signed in to change notification settings - Fork 155
Fix: await cache set #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: await cache set #446
Conversation
🦋 Changeset detectedLatest commit: 0a5d09c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I wonder if there's a lint that trigger Github to warn like it's warning the missing else clause below. At minimum, it would bring our attention to subtle things like this.
Yeah there is a bunch of them, i thought they was already included to be honest. I'll add them to the eslint config and fix any error that we found here |
Don't know how this one could have gone undetected, but set is not properly awaited.
I'll test this and merge this tomorrow, probably do a release as well.
Maybe the latest PR was not even entirely necessary