Skip to content

refactor(cloudflare): rename the "cloudflare" wrapper to "cloudflare-edge" #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-news-give.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

refactor(cloudflare): rename the "cloudflare" wrapper to "cloudflare-edge"
2 changes: 1 addition & 1 deletion packages/open-next/src/build/createMiddleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export async function createMiddleware(
buildHelper.copyOpenNextConfig(
options.buildDir,
outputPath,
config.middleware.override?.wrapper === "cloudflare",
await buildHelper.isEdgeRuntime(config.middleware.override),
);

// Bundle middleware
Expand Down
7 changes: 2 additions & 5 deletions packages/open-next/src/build/edge/createEdgeBundle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import logger from "../../logger.js";
import { openNextEdgePlugins } from "../../plugins/edge.js";
import { openNextReplacementPlugin } from "../../plugins/replacement.js";
import { openNextResolvePlugin } from "../../plugins/resolve.js";
import type { BuildOptions } from "../helper.js";
import { type BuildOptions, isEdgeRuntime } from "../helper.js";
import { copyOpenNextConfig, esbuildAsync } from "../helper.js";

interface BuildEdgeBundleOptions {
Expand Down Expand Up @@ -52,10 +52,7 @@ export async function buildEdgeBundle({
onlyBuildOnce,
name,
}: BuildEdgeBundleOptions) {
const isInCloudfare =
typeof overrides?.wrapper === "string"
? overrides.wrapper === "cloudflare"
: (await overrides?.wrapper?.())?.edgeRuntime;
const isInCloudfare = await isEdgeRuntime(overrides);
await esbuildAsync(
{
entryPoints: [entrypoint],
Expand Down
20 changes: 19 additions & 1 deletion packages/open-next/src/build/helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ import url from "node:url";

import type { BuildOptions as ESBuildOptions } from "esbuild";
import { build as buildAsync, buildSync } from "esbuild";
import type { OpenNextConfig } from "types/open-next.js";
import type {
DefaultOverrideOptions,
OpenNextConfig,
} from "types/open-next.js";

import logger from "../logger.js";

Expand Down Expand Up @@ -356,3 +359,18 @@ export function initOutputDir(options: BuildOptions) {
fs.mkdirSync(buildDir, { recursive: true });
fs.cpSync(options.tempBuildDir, buildDir, { recursive: true });
}

/**
* @returns Whether the edge runtime is used
*/
export async function isEdgeRuntime(
overrides: DefaultOverrideOptions | undefined,
) {
if (!overrides?.wrapper) {
return false;
}
if (typeof overrides.wrapper === "string") {
return ["cloudflare-edge", "cloudflare"].includes(overrides.wrapper);
}
return (await overrides?.wrapper?.())?.edgeRuntime;
}
3 changes: 2 additions & 1 deletion packages/open-next/src/build/validateConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ const compatibilityMatrix: Record<IncludedWrapper, IncludedConverter[]> = {
],
"aws-lambda-streaming": ["aws-apigw-v2"],
cloudflare: ["edge"],
"cloudflare-streaming": ["edge"],
"cloudflare-edge": ["edge"],
"cloudflare-node": ["edge"],
node: ["node"],
dummy: [],
};
Expand Down
4 changes: 2 additions & 2 deletions packages/open-next/src/helpers/withCloudflare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function withCloudflare<
routes: [fn.routes],
patterns: [fn.patterns],
override: {
wrapper: "cloudflare",
wrapper: "cloudflare-edge",
converter: "edge",
},
}
Expand All @@ -110,7 +110,7 @@ export function withCloudflare<
external: true,
originResolver: "pattern-env",
override: {
wrapper: "cloudflare",
wrapper: "cloudflare-edge",
converter: "edge",
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const handler: WrapperHandler<

export default {
wrapper: handler,
name: "cloudflare",
name: "cloudflare-edge",
supportStreaming: true,
edgeRuntime: true,
} satisfies Wrapper<InternalEvent, InternalResult | MiddlewareOutputEvent>;
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ const handler: WrapperHandler<InternalEvent, InternalResult> =

export default {
wrapper: handler,
name: "cloudflare-streaming",
name: "cloudflare-node",
supportStreaming: true,
} satisfies Wrapper;
7 changes: 6 additions & 1 deletion packages/open-next/src/plugins/resolve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,19 @@ export function openNextResolvePlugin({
build.onLoad({ filter: /core(\/|\\)resolve\.js/g }, async (args) => {
let contents = readFileSync(args.path, "utf-8");
const overridesEntries = Object.entries(overrides ?? {});
for (const [overrideName, overrideValue] of overridesEntries) {
for (let [overrideName, overrideValue] of overridesEntries) {
if (!overrideValue) {
continue;
}
if (overrideName === "wrapper" && overrideValue === "cloudflare") {
// "cloudflare" is deprecated and replaced by "cloudflare-edge".
overrideValue = "cloudflare-edge";
}
const folder =
nameToFolder[overrideName as keyof typeof nameToFolder];
const defaultOverride =
defaultOverrides[overrideName as keyof typeof defaultOverrides];

contents = contents.replace(
`../overrides/${folder}/${defaultOverride}.js`,
`../overrides/${folder}/${getOverrideOrDummy(overrideValue)}.js`,
Expand Down
4 changes: 3 additions & 1 deletion packages/open-next/src/types/open-next.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ export type IncludedWrapper =
| "aws-lambda"
| "aws-lambda-streaming"
| "node"
// @deprecated - use "cloudflare-edge" instead.
| "cloudflare"
| "cloudflare-streaming"
| "cloudflare-edge"
| "cloudflare-node"
| "dummy";

export type IncludedConverter =
Expand Down