You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick change to avoid warnings such as:
when using the Cloudflare adapter
I am not a huge fan of this change but, for a quick fix which doesn't require too much refactoring in the aws package, I think it's either this or patching the aws code on the Cloudflare adapter (as I've done in opennextjs/opennextjs-cloudflare#211).
(A more proper fix would be to make the aws code configurable so that when used by the Cloudflare adapter the setNodeEnv is either never called, thus three shaken away, or becomes a no-op function, but that as I referred to before would be a much bigger change, which might not be worth it right now)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not a big fan of this change either to be honest. We need to find a better way of defining this (or delegate it to the platform itself).
Order of import can cause this issue #624
LGTM Not a big fan of this change either to be honest. We need to find a better way of defining this (or delegate it to the platform itself). Order of import can cause this issue #624
thanks 🙂
yeah I agree it does feel like this could be improved 😕
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dario-piotrowicz
force-pushed
the
dario/setNodeEnv-warning-fix
branch
from
This is a quick change to avoid warnings such as:
when using the Cloudflare adapter
I am not a huge fan of this change but, for a quick fix which doesn't require too much refactoring in the aws package, I think it's either this or patching the aws code on the Cloudflare adapter (as I've done in opennextjs/opennextjs-cloudflare#211).
(A more proper fix would be to make the aws code configurable so that when used by the Cloudflare adapter the
setNodeEnvis either never called, thus three shaken away, or becomes a no-op function, but that as I referred to before would be a much bigger change, which might not be worth it right now)