Skip to content

fix: should return 400 in image optimization when Next passes errorMessage #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2025
Merged

fix: should return 400 in image optimization when Next passes errorMessage #830

merged 7 commits into from
Apr 15, 2025

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Apr 14, 2025 •
edited
Loading

For #826

In versions 13, 14, and 15, next start returns a 400 Bad Request if validateImageParams returns an errorMessage. We should align with this behavior.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7e8b658

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 14, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@830

commit: 80832b3

@sommeeeer sommeeeer changed the title fix: should return 400 in image optimization when next passes an erro… fix: should return 400 in image optimization when Next passes errorMessage Apr 14, 2025
@sommeeeer sommeeeer marked this pull request as ready for review April 15, 2025 12:51
@iDVB iDVB mentioned this pull request Apr 15, 2025
Closed
khuezy
khuezy approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

conico974
conico974 reviewed Apr 15, 2025
View reviewed changes
@sommeeeer sommeeeer requested review from khuezy and conico974 April 15, 2025 18:41
conico974
conico974 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit af2fd9d into opennextjs:main Apr 15, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Merged
@sommeeeer sommeeeer deleted the image-400 branch April 15, 2025 18:48
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

@khuezy khuezy Awaiting requested review from khuezy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sommeeeer @khuezy @conico974