add e2e for next/head and next/amp in pages router #845
Conversation
|
| test("should load and display the timeago component", async ({ page }) => { | ||
| await page.goto("/amp"); | ||
| const timeago = await page.getByTestId("amp-timeago").textContent(); | ||
| expect(timeago).toBe("just now"); |
There was a problem hiding this comment.
How precise is it ?
Could it display a 1s ago ?
There was a problem hiding this comment.
How precise is it ?
In theory it should be always showing just now here as the value is calculated at render time, and that wont take many ms. Its using format() from timeago.js under the hood, and it will show just now until it reaches 10s, then it will start showing 10 seconds ago.
There was a problem hiding this comment.
I can add a comment about it in the test.
|
LGTM Thanks |
For #842