fix cache control for static page with base path #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f7c130 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
May 27, 2025
| @@ -245,7 +245,9 @@ export function fixCacheHeaderForHtmlPages( | |||
| // https://opennext.js.org/aws/v2/advanced/workaround#workaround-nextserver-does-not-set-cache-headers-for-html-pages | |||
| // Requests containing an `x-middleware-prefetch` header must not be cached | |||
| if ( | |||
| HtmlPages.includes(localizedPath) && | |||
| HtmlPages.find( | |||
| (path) => `${NextConfig.basePath ?? ""}${path}` === localizedPath, | |||
There was a problem hiding this comment.
nit: instead of having to string concat time, you could compare to localizedPathFromBasePath that would be computed once before the loop
There was a problem hiding this comment.
Ho this made me realize, this might not be correct when both i18n and basePath are set.
I'll convert this one to draft and make a release in the meantime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872