feat: pass cli arguments not used by opennext to wrangler #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efda97e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
commit: |
vicb
reviewed
Jun 9, 2025
vicb
reviewed
Jun 9, 2025
james-elicx
commented
Jun 9, 2025
Co-authored-by: Victor Berchet <victor@suumit.com>
vicb
reviewed
Jun 9, 2025
vicb
reviewed
Jun 9, 2025
vicb
reviewed
Jun 11, 2025
| if (name && !(name in options)) { | ||
| passthroughArgs.push(args[i]!); | ||
|
|
||
| while (!args[i + 1]?.startsWith("-")) { |
There was a problem hiding this comment.
Thanks for the update.
I find the new version much more readable.
Still wondering why we have a while here.
I get the --flagName flagValue thing but why more strings after flagValue ?
There was a problem hiding this comment.
i was assuming array arguments might be able to be provided without specifying the key each time, e.g. --flagName flagValue1 flagValue2. yargs calls it greedy arrays - https://github.com/yargs/yargs-parser/blob/main/README.md#greedy-arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.