fix: disable instead of removing middleware from lambda

Author: pieh

src/build/content/server.ts

@@ -21,6 +21,7 @@ import { prerelease, satisfies, lt as semverLowerThan, lte as semverLowerThanOrE
 import type { RunConfig } from '../../run/config.js'
 import { RUN_CONFIG_FILE } from '../../run/constants.js'
 import type { PluginContext, RequiredServerFilesManifest } from '../plugin-context.js'
+import type { MiddlewareManifest } from 'next/dist/build/webpack/plugins/middleware-plugin.js'
 
 const tracer = wrapTracer(trace.getTracer('Next runtime'))
 
@@ -324,23 +325,37 @@ export const copyNextDependencies = async (ctx: PluginContext): Promise<void> =>
 }
 
 /**
- * Generates a copy of the middleware manifest without any middleware in it. We
+ * Generates a copy of the middleware manifest that make all matchers never match on anything. We
  * do this because we'll run middleware in an edge function, and we don't want
- * to run it again in the server handler.
+ * to run it again in the server handler. Additionally Next.js conditionally enable some handling
+ * depending if there is a middleware present, so we need to keep reference to middleware in server
+ * even if we don't actually want to ever run it there.
  */
 const replaceMiddlewareManifest = async (sourcePath: string, destPath: string) => {
   await mkdir(dirname(destPath), { recursive: true })
 
   const data = await readFile(sourcePath, 'utf8')
-  const manifest = JSON.parse(data)
+  const manifest = JSON.parse(data) as MiddlewareManifest
 
   // TODO: Check for `manifest.version` and write an error to the system log
   // when we find a value that is not equal to 2. This will alert us in case
   // Next.js starts using a new format for the manifest and we're writing
   // one with the old version.
   const newManifest = {
     ...manifest,
-    middleware: {},
+    middleware: Object.fromEntries(
+      Object.entries(manifest.middleware).map(([key, edgeFunctionDefinition]) => {
+        // we can mutate in place here is we have throw away copy of middleware manifest not used anywhere else
+        edgeFunctionDefinition.matchers = edgeFunctionDefinition.matchers.map((matcher) => {
+          return {
+            ...matcher,
+            // matcher that won't match on anything
+            regexp: '(?!.*)',
+          }
+        })
+        return [key, edgeFunctionDefinition]
+      }),
+    ),
   }
   const newData = JSON.stringify(newManifest)