Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CredentialsExpired exception in worker #84

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Conversation

mre
Copy link
Contributor

@mre mre commented Apr 20, 2024

This requires a version bump of the Spotify Connector,
because it wasn't exposed before

Spotify Connector 0.8.2 release: https://pypi.org/project/spotifyconnector/0.8.2/

Fixes #83

mre added 4 commits April 20, 2024 18:49
we use it in other jobs as well
This requires a version bump of the Spotify Connector,
because it wasn't exposed before
@mre mre requested a review from woolfg April 20, 2024 16:51
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks crazy, but I just wrapped the entire thing in a try-catch block. 😆

Copy link
Contributor

@woolfg woolfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, cool 👍

@woolfg woolfg merged commit 11c1a03 into main Apr 20, 2024
12 checks passed
@woolfg woolfg deleted the fix/83-catch-login-error branch April 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch login error when cookie is outdated and report it so we can process it in grafana
2 participants