Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Spotify for Creators' impressions support #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 'Spotify for Creators' impressions support #90

wants to merge 1 commit into from

Conversation

mre
Copy link
Contributor

@mre mre commented Dec 24, 2024 •
edited
Loading

This was referenced Jan 24, 2025
Open
Open
@mre mre requested a review from woolfg January 24, 2025 16:56
woolfg
woolfg requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@woolfg woolfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. we just have to make sure to set the right date range for the api

anchor/job/__main__.py
anchor.impressions,
date_range.end
),
start_date=date_range.start,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is always last 30 days. so we have to send the correct date range to the api as the values are stored with this date range in the DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woolfg woolfg woolfg requested changes

Assignees

@woolfg woolfg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mre @woolfg