Fix: Fix the Dockerfile and the README.md #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions used in the Dockerfile as well as the README.md didnt seems to be up to date. I also add the build part for the Dockerfile. This would help to be independant from any previous java/maven installation on the the build host. Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
|
@oferrigni @kickroot @belosh59 Is that okay to ping you in that way ? |
|
Yep @JGodin-C2C, thanks for the MR. I hope to get to this today. |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions used in the Dockerfile as well as the README.md didnt seems to be up to date.
I also add the build part for the Dockerfile. This would help to be independant from any previous java/maven installation on the the build host.
I also would like to state that i am not really a java developer and that i have changed the build process as it was failing probably due to a double goal .
Feel free to comment.