Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
ChangeMethodNameVisitor
class.What's changed?
getType()
returns a JavaType, changed it togetMethodType()
.withType()
we have to mention thewithMethodType()
as well or it will give the error of missing type or invalid type error.What's your motivation?
I was making a recipe to change the method name, when I refered docs I used the code provided in the
ChangeMethodNameVisitor
but it errored tomissing type or invalid type in LST
. Then I made the required changes, maybe this was the correct one used before. But now the current change works.I reffered this https://github.com/openrewrite/rewrite/blob/main/rewrite-java/src/main/java/org/openrewrite/java/ChangeMethodName.java#L103-L110
Before:
Or also change made in 2 cycles error.
After:
No error, recipe works fine.
Checklist