Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring BNF coding systems import data to be like other tests #2335

Open
StevenMaude opened this issue Feb 6, 2025 · 0 comments
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work

Comments

@StevenMaude
Copy link
Contributor

As mentioned in #2264, test_import_data.py for the BNF coding system currently uses a pytest fixture for the data to be imported.

Other analogous tests for other coding systems use repository data fixtures instead; example.

We could make these tests slightly more uniform by making the BNF import data tests do the same: use a repository data fixture, instead of a generated-by-pytest fixture.

On the other hand, we may later refactor these code and tests entirely, and it may not be worth doing.

@StevenMaude StevenMaude added the deck-scrubbing Tech debt or other between-initiative tidy-up work label Feb 6, 2025
@StevenMaude StevenMaude mentioned this issue Feb 6, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deck-scrubbing Tech debt or other between-initiative tidy-up work
Projects
None yet
Development

No branches or pull requests

1 participant