Replace pysqlite3-binary with sqlean.py #1824
Merged
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advantage of sqlean.py is that it includes wheels for Windows, macOS, and Linux. pysqlite3-binary doesn't: it includes wheels only for Linux, and, based on the project's closed issues, that is the way it's going to stay. (Aside: sqlean.py's maintainer has dropped into pysqlite3-binary's issues to recommend sqlean.py over pysqlite3-binary [1][].) As we've made the switch in ehrQL, and as at least one member of the team doesn't develop on Linux (and has only so much patience for Docker), it would seem reasonable to replace the former for the latter. [1]: coleifer/pysqlite3#64
iaindillingham
force-pushed
the
iaindillingham/sqlean
branch
from
060ccfa to
9fc9a59
Compare
ghickman
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage of sqlean.py is that it includes wheels for Windows, macOS, and Linux. pysqlite3-binary doesn't: it includes wheels only for Linux, and, based on the project's closed issues, that is the way it's going to stay. (Aside: sqlean.py's maintainer has dropped into pysqlite3-binary's issues to recommend sqlean.py over pysqlite3-binary 1.)
As we've made the switch in ehrQL, and as at least one member of the team doesn't develop on Linux (and has only so much patience for Docker), it would seem reasonable to replace the former for the latter.