Take backups via sqlite ".backup"
#2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking backups via the sqlite CLI is simple and clean. We can restore from them. We haven't been able to locally restore from the `dumpdata` fixtures-based backups. For now, keep the old-format backups just in case we want to try to restore again to from them. After 30 days of creating new backups we can update the script to not consider the old format and location. Start taking backups in `/storage/backup` rather than directly in `/storage` to aid navigation and management of backups. Set -x in `backup.sh` to print the commands used as this aids remote debugging.
Jongmassey
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
This looks great, have you considered using zstd instead of gz here? It's installed on dokku3 and is significantly faster for the same file sizes
time gzip -f db.sqlite3
real 2m36.764s
user 2m30.439s
sys 0m3.521s
1.1G Dec 11 12:52 db.sqlite3.gz
time zstd db.sqlite3 -o db.sqlite3.zstd
real 0m29.130s
user 0m24.160s
sys 0m10.851s
1.1G Dec 11 12:52 db.sqlite3.zstd
This was referenced Dec 12, 2024
|
#2248 for zstd compression. |
mikerkelly
added a commit
that referenced
this pull request
Feb 5, 2025
These lines were gradually removing old-format backups as they aged out past 30 days. Now there are none left, they do no useful work and are no longer required. We changed the format of backups from `.json` to `.sqlite3` in #2214 (cdbacb6) on Dec 9, 2024. We changed the compression format from `gzip` to `Zstandard` in #2248 (7984176) on Dec 16, 2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2151. ADR about the core backup strategy will be in a separate PR.
Taking backups via the sqlite CLI is simple and clean. We can restore from them.
We haven't been able to locally restore from the
dumpdatafixtures-based backups. For now, keep the old-format backups just in case we want to try again to restore from them. After 30 days of creating new backups we can update the script to not consider the old format and location.See these comments about the execution time and file system space requirements.