Fix location of DB to take backup from #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the container, /app/db.sqlite3 is an apparently empty DB, /storage/db.sqlite3 is the actual app DB of several GB. I'm not sure why the former exists. But this script was backing that up, not the intended DB. For example, when this ran in production as scheduled the first time the produced backup file is only a few tens of bytes in size. ``` mikerkelly@dokku3:~$ ls /var/lib/dokku/data/storage/opencodelists/backup/db/ -lrth total 4.0K -rw-r--r-- 1 opencodelists opencodelists 114 Dec 12 01:00 2024-12-12-db.sqlite3.gz ```
Make the target a relative path -- an absolute one won't mean the same thing in the host file system if executed inside a container as we expect. For example, when this ran in production as scheduled the first time I realized the symlink refers to /storage/ which doesn't work in the host file system -- and therefore can't be used over SCP for example: ``` mikerkelly@dokku3:~$ ls /var/lib/dokku/data/storage/opencodelists/backup/db/ -lrth total 4.0K -rw-r--r-- 1 opencodelists opencodelists 114 Dec 12 01:00 2024-12-12-db.sqlite3.gz lrwxrwxrwx 1 opencodelists opencodelists 43 Dec 12 01:00 latest-db.sqlite3.gz -> /storage/backup/db/2024-12-12-db.sqlite3.gz ``` Be slightly more precise about what's a file "name" vs file "path".
mikerkelly
changed the title
Jongmassey
requested changes
Dec 13, 2024
The path for the core and coding system databases is set by the DATABASE_DIR environment variable, which is managed via the dokku config described in DEPLOY.md. By using that env var in this backup script, we ensure that if the configuration of this variable changes then this script will continue to work.
Jongmassey
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2214, which was broken. Partially fixes #2151.
Within the container, /app/db.sqlite3 is an apparently empty DB, /storage/db.sqlite3 is the actual app DB of several GB. I'm not sure why the former exists. But this script was backing that up, not the intended DB.
For example, when this ran in production as scheduled the first time the produced backup file is only a few tens of bytes in size.