Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handlebars, change structure and a configured based build #13

Merged
merged 5 commits into from
Jan 9, 2018

Conversation

guidiego
Copy link
Contributor

@guidiego guidiego commented Jan 9, 2018

Update!

Basicamente refatorei o projeto pra modularizar caso bater a loca e a gente queira mudar o layout pro ano que vem ❤️ Ainda falta uns toques finais pra deixar SUPIMPA, vou abrir algumas issues assinadas pra mim, porem o projeto ta atualizado e os dados sendo projetados dinamicamente atraves dos .json dentro de src/events/YEAR.json, o build que subi ja ta com os dados de 2018 :)

Comando:
gulp --year <YEAR_OF_JSON>

Sample:
gulp --year 2018

Issues pra mais tarde:
#14
#15

@guidiego guidiego self-assigned this Jan 9, 2018
@guidiego guidiego changed the title Chore/add dynamic template Add handlebars, change structure and a configured based build Jan 9, 2018
Copy link
Member

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pq foi removido o package.json?. Não é interessante manter ele para controlar as dependencias? (como o gulp)

Copy link
Member

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei um comment acima sobre uma questão. E faça o squash dos commits. Vlww

🍻

<h2 class="section-title"> DevConf</h2>
<br>
<p>
Acreditamos que o conhecimento é livre, e essa crença nos inspirou a organizar o DevConf!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidiego como esse texto pode ser alterado a cada ano, eu iria sugerir em colocar ele no arquivo json também.

🍻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm toppen!

<div id="google-container"></div>
<div id="cd-zoom-in"></div>
<div id="cd-zoom-out"></div>
<address>Anfiteatro Bento Prado Junior - UFSCar | Rod. Washington Luis, km 235 - São Carlos/SP</address>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aqui também. Colocar para pegar do json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No caso precisa por o link do google maps tbm n ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que o google faz isso dinamicamente. Só colocar esse address. AFAIK.

<div class="footer__info-brand">
<img src="assets/img/opensanca.svg" alt="DevConf - Somos Caipiras e gostamos de Tecnologia">
<p>
DevConf - Somos caipiras e gostamos de tecnologia © Opensanca 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usar o ano do evento dinamicamente.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

<div class="footer__more">
<div class="footer__links">
<ul>
<li><a href="codigo-conduta-devconf.html" target="_blank">Código de Conduta DevConf 2017</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui também. Usar o ano do evento dinamicamente.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup

<div class="dropdown__link__info">
<h2 class="dropdown__link__title">Lote I</h2>
<div class="col-md-6">
<i class="fa fa-calendar-o"></i> até 11/04 <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eu colocaria esses preços dentro do json também.
algo como:

prices: {
  tickets_1: { name: 'Lote I', until_date: '11/04', price: 'R$ 40,00' },
  tickets_2: { name: 'Lote 2', until_date: '21/04', price: 'R$ 50,00' },
  ...
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e talvez o link de destino também:

prices: {
  tickets_url: 'http://...',
  tickets_1: { name: 'Lote I', until_date: '11/04', price: 'R$ 40,00' },
  tickets_2: { name: 'Lote 2', until_date: '21/04', price: 'R$ 50,00' },
  ...
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem uma issue pra isso <3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boa 🍺

@guidiego
Copy link
Contributor Author

guidiego commented Jan 9, 2018

@duduribeiro tirando os seus comentarios que dei um YUp, os outros podiamos criar issue e postergar (que nem fiz com partes que achei irrelevante pro momento, assim podemos focar em soltar a versao pro se mandar pros patrocinadores) que que acha ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants