[Calcite] Build integration test framework #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
|
Current CI will still fail due to missing security policy in job-schedule plugin. cc @xinyuan Review required cc @qianheng-aws @penghuo @dai-chen |
| fallbackAllowed = settings.getSettingValue(Settings.Key.CALCITE_FALLBACK_ALLOWED); | ||
| } | ||
| if (!fallbackAllowed) { | ||
| throw e; |
There was a problem hiding this comment.
Shall we use listener to handle this exception?
listener.onFailure(e);
| * This abstract test case provide a standalone env to run PPL query, IT extends this class could | ||
| * debug the service side execution of PPL in IDE. | ||
| */ | ||
| public abstract class CalcitePPLTestCase extends PPLIntegTestCase { |
There was a problem hiding this comment.
Just curious why do we change this name? The current name doesn't explicitly indicate that this's an integ test.
| @@ -0,0 +1,185 @@ | |||
| /* | |||
| * Copyright OpenSearch Contributors | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
I think we should add calcite's license header after ours since we copy code from that repo.
There is similar example in
Signed-off-by: Lantao Jin <ltjin@amazon.com>
penghuo
approved these changes
Feb 25, 2025
…estCase Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
merged commit 4ba78d3
into
opensearch-project:feature/calcite-engine
8 of 13 checks passed
|
Thanks, merging to dev branch. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build integration test framework, includes
plugins.calcite.enabledandplugins.calcite.fallback.allowedCalciteToolsHelper.java, this class is used to create customized Connection, JavaTypeFactory, RelBuilder and RelRunnervalueForCalcite()inExprValue, calcite read opensearch data byvalueForCalcite()instead ofvalue()EnumerableIndexScanRuleto convert a CalciteLogicalTableScan to CalciteOpenSearchIndexScan`Related Issues
Resolves #3330
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.