Make basic aggregation working (part 2) : adding tests #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
changed the title
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
penghuo
approved these changes
Feb 26, 2025
Comment on lines
+155
to
+160
| case INTERVAL_YEAR: | ||
| case INTERVAL_MONTH: | ||
| case INTERVAL_DAY: | ||
| case INTERVAL_HOUR: | ||
| case INTERVAL_MINUTE: | ||
| case INTERVAL_SECOND: |
There was a problem hiding this comment.
spark-ppl support YearMonthIntervalType and DayTimeIntervalType? if yes, we can track it as issue and fix later.
There was a problem hiding this comment.
no, YearMonthIntervalType and DayTimeIntervalType are not supported in spark-ppl
this code is not in use for now.
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
merged commit c2fe0ad
into
opensearch-project:feature/calcite-engine
5 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup of #3318
Related Issues
Resolves #3308
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.