Add partial udf #3363
Open
Add partial udf #3363
+1,184
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: Xinyuan Lu <xinyual@amazon.com>
Map opensearch math functions to calcite implementations
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
xinyual
requested review from
ykmr1224,
LantaoJin and
noCharger
as code owners
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
|
LantaoJin
reviewed
Feb 27, 2025
| @@ -44,7 +44,7 @@ apply plugin: 'java' | |||
| apply plugin: 'io.freefair.lombok' | |||
| apply plugin: 'com.wiredforcode.spawn' | |||
|
|
|||
| String baseVersion = "2.17.0" | |||
| String baseVersion = "2.17.1" | |||
| @@ -5,9 +5,16 @@ | |||
|
|
|||
| package org.opensearch.sql.calcite.standalone; | |||
|
|
|||
| import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_BANK; | |||
| import static org.opensearch.sql.legacy.TestsConstants.*; | |||
There was a problem hiding this comment.
Do not use * in imports. (disable merging imports in IDE)
|
|
||
| @Ignore | ||
| @Test | ||
| public void testDate() { |
There was a problem hiding this comment.
Move all functions related tests to a new CalcitePPLBuiltinFunctionIT, this one is not for functions ITs.
| @@ -0,0 +1,5 @@ | |||
| package org.opensearch.sql.calcite.udf; | |||
There was a problem hiding this comment.
new file should include a copyright header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add several UDFs and UDAFs. We add implement for functions which exist in both index PPL and Spark PPL from #3310.
Briefly, we implement all math/string/condition functions list in #3310 plus percentile and take aggregation.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.