Skip to content

Commit 690a678

Browse files
authored
fix bug: UMN documentation link returns 404 (#2877)
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
1 parent ae77f39 commit 690a678

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

libs/ui-lib/lib/common/config/docs_links.ts

+14-7
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
1-
const DEFAULT_OPENSHIFT_DOCS_VERSION = '4.15';
1+
const DEFAULT_OPENSHIFT_DOCS_VERSION = 4.15;
22

33
export const getShortOpenshiftVersion = (ocpVersion?: string) => {
4-
let shortOcpVersion = ocpVersion
5-
? ocpVersion.split('.').slice(0, 2).join('.')
6-
: DEFAULT_OPENSHIFT_DOCS_VERSION;
7-
if (shortOcpVersion < '4.14') shortOcpVersion = '4.14';
8-
return shortOcpVersion;
4+
if (!ocpVersion) {
5+
return DEFAULT_OPENSHIFT_DOCS_VERSION;
6+
}
7+
const versionXY = Number(ocpVersion.split('.').slice(0, 2).join('.'));
8+
if (!Number.isFinite(versionXY)) {
9+
return DEFAULT_OPENSHIFT_DOCS_VERSION;
10+
}
11+
return versionXY < 4.14 ? 4.14 : versionXY;
912
};
1013

1114
export const getYearForAssistedInstallerDocumentationLink = () => {
@@ -36,7 +39,11 @@ export const getEncryptingDiskDuringInstallationDocsLink = (ocpVersion?: string)
3639
export const getOpenShiftNetworkingDocsLink = (ocpVersion?: string) =>
3740
`https://docs.redhat.com/en/documentation/openshift_container_platform/${getShortOpenshiftVersion(
3841
ocpVersion,
39-
)}/html/installing_on_bare_metal/installing-bare-metal#installation-network-user-infra_installing-bare-metal`;
42+
)}/html/installing_on_bare_metal/${
43+
getShortOpenshiftVersion(ocpVersion) > 4.17
44+
? 'user-provisioned-infrastructure'
45+
: 'installing-bare-metal'
46+
}#installation-network-user-infra_installing-bare-metal`;
4047

4148
export const SSH_GENERATION_DOC_LINK = 'https://www.redhat.com/sysadmin/configure-ssh-keygen';
4249

0 commit comments

Comments
 (0)