Skip to content

Commit c17a789

Browse files
authored
Show all OCP versions in dropdown (maintenance, production, beta, end-of-life) (#2552) (#2555)
1 parent 9316a67 commit c17a789

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

libs/ui-lib/lib/common/components/clusterConfiguration/OpenShiftVersionSelect.tsx

+8-7
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ const getOpenshiftVersionHelperText =
3535
return null;
3636
}
3737

38-
if (selectedVersion.supportLevel !== 'production') {
38+
if (
39+
selectedVersion.supportLevel !== 'production' &&
40+
selectedVersion.supportLevel !== 'maintenance'
41+
) {
3942
return (
4043
<>
4144
<UiIcon size="sm" status="warning" icon={<ExclamationTriangleIcon />} />
@@ -55,12 +58,10 @@ type OpenShiftVersionSelectProps = {
5558
const OpenShiftVersionSelect: React.FC<OpenShiftVersionSelectProps> = ({ versions, onChange }) => {
5659
const selectOptions = React.useMemo(
5760
() =>
58-
versions
59-
.filter((version) => version.supportLevel !== 'maintenance')
60-
.map((version) => ({
61-
label: version.label,
62-
value: version.value,
63-
})),
61+
versions.map((version) => ({
62+
label: version.label,
63+
value: version.value,
64+
})),
6465
[versions],
6566
);
6667
const { t } = useTranslation();

libs/ui-lib/lib/ocm/components/clusterConfiguration/OcmOpenShiftVersionSelect.tsx

+13-12
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ const getOpenshiftVersionHelperText = (
4444
return null;
4545
}
4646

47-
if (selectedVersion.supportLevel !== 'production') {
47+
if (
48+
selectedVersion.supportLevel !== 'production' &&
49+
selectedVersion.supportLevel !== 'maintenance'
50+
) {
4851
let messageSelectedVersion = t('ai:Please note that this version is not production-ready.');
4952
if (selectedVersion.supportLevel === 'end-of-life') {
5053
messageSelectedVersion = t('ai:Please note that this version is not maintained anymore.');
@@ -72,17 +75,15 @@ const OcmOpenShiftVersionSelect = ({ versions }: OcmOpenShiftVersionSelectProps)
7275
} = useFormikContext<ClusterDetailsValues>();
7376
const selectOptions = React.useMemo(
7477
() =>
75-
versions
76-
.filter((version) => version.supportLevel !== 'maintenance')
77-
.map((version) => ({
78-
label:
79-
version.supportLevel === 'beta'
80-
? version.label + ' - ' + t('ai:Developer preview release')
81-
: version.label,
82-
// This is the "key" from openshift-versions API response
83-
// It can either be in the long or short (for default versions) form
84-
value: version.value,
85-
})),
78+
versions.map((version) => ({
79+
label:
80+
version.supportLevel === 'beta'
81+
? version.label + ' - ' + t('ai:Developer preview release')
82+
: version.label,
83+
// This is the "key" from openshift-versions API response
84+
// It can either be in the long or short (for default versions) form
85+
value: version.value,
86+
})),
8687
[versions, t],
8788
);
8889
const [isOpenshiftVersionModalOpen, setIsOpenshiftVersionModalOpen] = React.useState(false);

0 commit comments

Comments
 (0)