Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16970: BMH status not updated in console during provisioning phase #2507

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jgyselov
Copy link
Contributor

@jgyselov jgyselov requested a review from a team as a code owner February 21, 2024 14:32
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2024

@jgyselov: This pull request references MGMT-16970 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-16970

Adds missing argument.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2024
@jgyselov jgyselov requested a review from rawagner February 27, 2024 14:13
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

openshift-ci bot commented Mar 4, 2024

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov merged commit 41872af into openshift-assisted:master Mar 4, 2024
7 checks passed
jgyselov added a commit to jgyselov/assisted-installer-ui that referenced this pull request May 29, 2024
…se (openshift-assisted#2507)

* Fix BMH status in table

* Memoize BMH and agent statuses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants