Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17013: Solving problems with icon's color that are incorrect in Review&Create page #2508

Merged
merged 4 commits into from
Mar 1, 2024
Merged

MGMT-17013: Solving problems with icon's color that are incorrect in Review&Create page #2508

merged 4 commits into from
Mar 1, 2024

Conversation

ammont82
Copy link
Member

Related to https://issues.redhat.com/browse/MGMT-17013

Solving problems with icon's color in Review&Create page:
Captura desde 2024-02-26 14-37-10
Captura desde 2024-02-26 14-26-41

@ammont82 ammont82 requested a review from a team as a code owner February 26, 2024 13:43
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot
Loading

@ammont82: This pull request references MGMT-17013 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17013

Solving problems with icon's color in Review&Create page:
Captura desde 2024-02-26 14-37-10
Captura desde 2024-02-26 14-26-41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 added this to the v2.31 milestone Feb 26, 2024
@ammont82 ammont82 added the OCM label Feb 26, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
@ammont82 ammont82 force-pushed the MGMT-17013-colors-warning-is-incorrect branch 2 times, most recently from 494d521 to c804ec3 Compare February 28, 2024 10:37
@ammont82 ammont82 force-pushed the MGMT-17013-colors-warning-is-incorrect branch from c804ec3 to 560a329 Compare February 28, 2024 10:43
@ammont82 ammont82 requested a review from jgyselov March 1, 2024 06:46
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 3c90502 into openshift-assisted:master Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake left review comments

@jgyselov jgyselov jgyselov approved these changes

Assignees

@jgyselov jgyselov

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.31
Development

Successfully merging this pull request may close these issues.
4 participants
@ammont82 @openshift-ci-robot @celdrake @jgyselov