Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17118: Host agent name change, UX flow could be improved #2515

Merged
merged 1 commit into from
Mar 19, 2024
Merged

MGMT-17118: Host agent name change, UX flow could be improved #2515

merged 1 commit into from
Mar 19, 2024

Conversation

jgyselov
Copy link
Contributor

@jgyselov jgyselov commented Mar 5, 2024

@jgyselov jgyselov requested a review from a team as a code owner March 5, 2024 13:25
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references MGMT-17118 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-17118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov force-pushed the edit_agent_name_modal branch from 7e6413b to 6f5eb85 Compare March 19, 2024 12:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov merged commit b45794d into openshift-assisted:master Mar 19, 2024
7 checks passed
@jgyselov jgyselov added this to the v2.11-cim milestone Apr 2, 2024
jgyselov added a commit to jgyselov/assisted-installer-ui that referenced this pull request May 29, 2024
@jgyselov
Close agent name edit modal after save (openshift-assisted#2515)
de0b63c
@jgyselov jgyselov mentioned this pull request Jun 4, 2024
Merged
@jgyselov jgyselov mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees

@rawagner rawagner

@ammont82 ammont82

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v2.11-cim
Development

Successfully merging this pull request may close these issues.
4 participants
@jgyselov @openshift-ci-robot @rawagner @ammont82