Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17130: Add correct id to <HelperItem> components when shown errors #2517

Conversation

ammont82
Copy link
Member

@ammont82 ammont82 commented Mar 6, 2024

Related to https://issues.redhat.com/browse/MGMT-17130

Add correct id to component when it's an error:

image

@ammont82 ammont82 added the OCM label Mar 6, 2024
@ammont82 ammont82 added this to the v2.31 milestone Mar 6, 2024
@ammont82 ammont82 requested a review from a team as a code owner March 6, 2024 14:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024

@ammont82: This pull request references MGMT-17130 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17130

Add correct id to component when it's an error:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2024

@ammont82: This pull request references MGMT-17130 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17130

Add correct id to component when it's an error:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@mareklibra
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, mareklibra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit cf07898 into openshift-assisted:master Mar 8, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Mar 20, 2024
…rs (openshift-assisted#2517)

* Add id to HelperItem components to indicate errors

* Add tests for validations in New cluster page

* Changing id in HelperItem components to show errors
@ammont82 ammont82 removed this from the v2.31 milestone Mar 20, 2024
ammont82 added a commit that referenced this pull request Mar 20, 2024
…rs (#2517) (#2527)

* Add id to HelperItem components to indicate errors

* Add tests for validations in New cluster page

* Changing id in HelperItem components to show errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants