Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19415: Static IP form - Error test of default GW is incorrect for the case d… #2845

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Mar 9, 2025

https://issues.redhat.com/browse/MGMT-19415

before the fix:
the wrong error was shown when adding valid default GW indicates a wrong msg for the error, when there is not error that needs to be shown.
image

after the fix:
no error.
image

…escribed in the example

Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni requested a review from a team as a code owner March 9, 2025 14:52
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2025

@ElayAharoni: This pull request references MGMT-19415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-19415

before the fix:
the wrong error was shown when adding valid default GW indicates a wrong msg for the error, when there is not error that needs to be shown.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ammont82 and celdrake March 9, 2025 14:52
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 9, 2025

@ElayAharoni: This pull request references MGMT-19415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-19415

before the fix:
the wrong error was shown when adding valid default GW indicates a wrong msg for the error, when there is not error that needs to be shown.
image

after the fix:
no error.
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, ElayAharoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
…is-incorrect-for-the-case-described-in-the-example
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
Copy link

openshift-ci bot commented Mar 10, 2025

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 27826d1 into openshift-assisted:master Mar 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants