Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Memoize WizardFooter #2855

Merged
merged 1 commit into from
Mar 12, 2025
Merged

NO-ISSUE: Memoize WizardFooter #2855

merged 1 commit into from
Mar 12, 2025

Conversation

jgyselov
Copy link
Contributor

No description provided.

@jgyselov jgyselov added this to the v2.14-cim milestone Mar 11, 2025
@jgyselov jgyselov requested a review from a team as a code owner March 11, 2025 13:38
@jgyselov jgyselov force-pushed the wizard_footer_memo branch from 5410774 to 2b60ac0 Compare March 11, 2025 13:40
@rawagner
Copy link
Member

/approve
/lgtm

@rawagner
Copy link
Member

/ok-to-test

@jgyselov
Copy link
Contributor Author

/cherry-pick releases/v2.14-cim

@openshift-cherrypick-robot
Copy link

@jgyselov: once the present PR merges, I will cherry-pick it on top of releases/v2.14-cim in a new PR and assign it to you.

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgyselov jgyselov changed the title NO-ISSUE: Memoize Wizard Footer NO-ISSUE: Memoize WizardFooter Mar 11, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2025
@rawagner
Copy link
Member

/retest

@rawagner
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bcff5fb into openshift-assisted:master Mar 12, 2025
10 checks passed
@openshift-cherrypick-robot
Copy link

@jgyselov: new pull request created: #2860

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.14-cim
Development

Successfully merging this pull request may close these issues.
3 participants
@jgyselov @rawagner @openshift-cherrypick-robot