Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-20083: validation blocks Next button but leave Add Hosts enabled #2858

Conversation

ElayAharoni
Copy link
Contributor

https://issues.redhat.com/browse/MGMT-20083

fixed it by diasabling the add hosts and the next button whenever the is a sync error like in this case.
screenshot of the behavior after the fix:
image

Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni requested a review from a team as a code owner March 11, 2025 14:55
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2025

@ElayAharoni: This pull request references MGMT-20083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-20083

fixed it by diasabling the add hosts and the next button whenever the is a sync error like in this case.
screenshot of the behavior after the fix:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from batzionb and celdrake March 11, 2025 14:55
Copy link

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ElayAharoni
Once this PR has been reviewed and has the lgtm label, please assign ammont82 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2025
Copy link
Member

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we can fix this issue this way. The sync error could be due to some changes in networking page, which would mean if we click back, we get stuck on this one, unable to access networking to fix it.

I think we just need to add a proper support for determining version & CP count so that the sync error wont happen.

@jgyselov
Copy link
Contributor

I think we just need to add a proper support for determining version & CP count so that the sync error wont happen.

That is a work in progress.

@jgyselov
Copy link
Contributor

Fixed in #2861

@jgyselov jgyselov closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants