-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-20083: validation blocks Next button but leave Add Hosts enabled #2858
MGMT-20083: validation blocks Next button but leave Add Hosts enabled #2858
Conversation
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni: This pull request references MGMT-20083 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ElayAharoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we can fix this issue this way. The sync error could be due to some changes in networking page, which would mean if we click back, we get stuck on this one, unable to access networking to fix it.
I think we just need to add a proper support for determining version & CP count so that the sync error wont happen.
That is a work in progress. |
Fixed in #2861 |
https://issues.redhat.com/browse/MGMT-20083
fixed it by diasabling the add hosts and the next button whenever the is a sync error like in this case.

screenshot of the behavior after the fix: