Skip to content

MGMT-20082: Deploying 4/5 nodes control plane is blocked #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

jgyselov
Copy link
Contributor

@jgyselov jgyselov commented Mar 14, 2025

https://issues.redhat.com/browse/MGMT-20082
https://issues.redhat.com/browse/MGMT-20083

4 and 5 control planes nodes should not be allowed for OpenShift versions older than 4.18 and those that are -multi.

@jgyselov jgyselov added this to the v2.14-cim milestone Mar 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@jgyselov: This pull request references MGMT-20082 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-20082

4 and 5 control planes nodes should not be allowed for OpenShift versions older than 4.18 and those that are -multi.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from batzionb and rawagner March 14, 2025 11:33
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2025
@jgyselov jgyselov force-pushed the control_plane_nodes branch from 1aa8b14 to c039dd2 Compare March 14, 2025 11:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@jgyselov: This pull request references MGMT-20082 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-20082
https://issues.redhat.com/browse/MGMT-20083

4 and 5 control planes nodes should not be allowed for OpenShift versions older than 4.18 and those that are -multi.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
Copy link

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov force-pushed the control_plane_nodes branch from c039dd2 to 2e64fd2 Compare March 17, 2025 10:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
Copy link

openshift-ci bot commented Mar 17, 2025

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov merged commit 217c773 into openshift-assisted:master Mar 17, 2025
9 of 10 checks passed
@jgyselov
Copy link
Contributor Author

/cherry-pick releases/v2.14-cim

@openshift-cherrypick-robot

@jgyselov: #2861 failed to apply on top of branch "releases/v2.14-cim":

Applying: Force version fix
Applying: Allow HA CPN based on the selected OpenShift image
Using index info to reconstruct a base tree...
M	libs/locales/lib/en/translation.json
M	libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
M	libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Falling back to patching base and 3-way merge...
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDetailsFormFields.tsx
Auto-merging libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
CONFLICT (content): Merge conflict in libs/ui-lib/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsForm.tsx
Auto-merging libs/locales/lib/en/translation.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Allow HA CPN based on the selected OpenShift image

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants