-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-17500: Fix HostedCluster status CustomKubeconfig name #2862
ACM-17500: Fix HostedCluster status CustomKubeconfig name #2862
Conversation
@jparrill: This pull request references ACM-17500 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Welcome @jparrill! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉 |
Hi @jparrill. Thanks for your PR. I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
libs/ui-lib/lib/cim/components/Hypershift/DetailsPage/HypershiftKubeconfigDownload.tsx
Show resolved
Hide resolved
Changes required in the HC API to fix the resource name for the custom kubeconfig status field Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgyselov, jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick releases/v2.14-cim |
@jgyselov: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c9c87ad
into
openshift-assisted:master
@jgyselov: new pull request created: #2873 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes required in the HC API to fix the resource name for the custom kubeconfig status field
#Fixes ACM-17500