Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-17500: Fix HostedCluster status CustomKubeconfig name #2862

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

jparrill
Copy link
Contributor

Changes required in the HC API to fix the resource name for the custom kubeconfig status field

#Fixes ACM-17500

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@jparrill: This pull request references ACM-17500 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Changes required in the HC API to fix the resource name for the custom kubeconfig status field

#Fixes ACM-17500

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
@openshift-ci openshift-ci bot requested review from ammont82 and rawagner March 14, 2025 15:37
Copy link

openshift-ci bot commented Mar 14, 2025

Welcome @jparrill! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2025
Copy link

openshift-ci bot commented Mar 14, 2025

Hi @jparrill. Thanks for your PR.

I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2025
Changes required in the HC API to fix the resource name for the custom kubeconfig status field

Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@jgyselov
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
Copy link

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgyselov, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@jgyselov
Copy link
Contributor

/cherry-pick releases/v2.14-cim

@openshift-cherrypick-robot

@jgyselov: once the present PR merges, I will cherry-pick it on top of releases/v2.14-cim in a new PR and assign it to you.

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c9c87ad into openshift-assisted:master Mar 24, 2025
10 checks passed
@openshift-cherrypick-robot

@jgyselov: new pull request created: #2873

In response to this:

/cherry-pick releases/v2.14-cim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants