Skip to content

AGENT-1143: add reset button to disconnected assisted installer ui #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

AGENT-1143: add reset button to disconnected assisted installer ui #2866

merged 2 commits into from
Mar 24, 2025

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Mar 18, 2025 •
edited
Loading

https://issues.redhat.com/browse/AGENT-1143

still draft.. no review needed yet

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2025 •
edited by openshift-ci bot
Loading

@ElayAharoni: This pull request references AGENT-1143 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/AGENT-1143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ammont82 and jgyselov March 18, 2025 14:41
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2025
@ElayAharoni ElayAharoni self-assigned this Mar 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2025 •
edited by openshift-ci bot
Loading

@ElayAharoni: This pull request references AGENT-1143 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/AGENT-1143

still draft.. no review needed yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ElayAharoni ElayAharoni force-pushed the add-reset-button-to-disconnected-assisted-installer-ui branch from 76f7689 to dbc2ed7 Compare March 18, 2025 15:13
@nirfarkas
Copy link
Contributor

screenshots please (:

@ElayAharoni
Copy link
Contributor Author

@nirfarkas

image

image

@ElayAharoni ElayAharoni force-pushed the add-reset-button-to-disconnected-assisted-installer-ui branch 8 times, most recently from 5f65989 to 2742f0f Compare March 20, 2025 10:38
@ElayAharoni ElayAharoni force-pushed the add-reset-button-to-disconnected-assisted-installer-ui branch from 7d92fb1 to d85e073 Compare March 23, 2025 09:46
@ElayAharoni
add reset button to disconnected assisted installer ui
60c8c1b 
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni force-pushed the add-reset-button-to-disconnected-assisted-installer-ui branch from d85e073 to 60c8c1b Compare March 23, 2025 10:00
rawagner
rawagner requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, there is just one forgotten ; that needs to be removed.

@ElayAharoni @rawagner
Update apps/assisted-disconnected-ui/src/components/ResetSingleCluste…
4b64499 
…rModal.tsx

Co-authored-by: Rastislav Wagner <rawagner@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3cafd01 into openshift-assisted:master Mar 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@ammont82 ammont82 Awaiting requested review from ammont82

@jgyselov jgyselov Awaiting requested review from jgyselov

Assignees

@rawagner rawagner

@ElayAharoni ElayAharoni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElayAharoni @openshift-ci-robot @nirfarkas @rawagner