Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-1142: Disable Nutanix platform integration #2870

Merged
merged 2 commits into from
Mar 25, 2025
Merged

AGENT-1142: Disable Nutanix platform integration #2870

merged 2 commits into from
Mar 25, 2025

Conversation

ElayAharoni
Copy link
Contributor

https://issues.redhat.com/browse/AGENT-1142

disabled Nutanix integration for disconnected env

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2025 •
edited by openshift-ci bot
Loading

@ElayAharoni: This pull request references AGENT-1142 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/AGENT-1142

disabled Nutanix integration for disconnected env

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from batzionb and jgyselov March 20, 2025 13:01
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2025
@ElayAharoni ElayAharoni requested a review from rawagner March 20, 2025 14:10
rawagner
rawagner reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, we should remove the option completely, not just disable.
As in disconnected, there is no configuration that user could do to make it enabled.

@ElayAharoni
Copy link
Contributor Author

after new fix:
image

@ElayAharoni ElayAharoni force-pushed the Disable-Nutanix-platform-integration branch from 0458245 to 46cf16a Compare March 23, 2025 09:24
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2025
@ElayAharoni ElayAharoni force-pushed the Disable-Nutanix-platform-integration branch 2 times, most recently from 178cdf5 to 5203285 Compare March 24, 2025 10:57
@ElayAharoni
Disable Nutanix platform integration
b935176 
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni force-pushed the Disable-Nutanix-platform-integration branch from 5203285 to b935176 Compare March 24, 2025 14:08
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2025
@rawagner
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@rawagner
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@rawagner
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 04dd337 into openshift-assisted:master Mar 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@batzionb batzionb Awaiting requested review from batzionb

@jgyselov jgyselov Awaiting requested review from jgyselov

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElayAharoni @openshift-ci-robot @rawagner