Skip to content

MGMT-19287: fix grid in host discovery alignment #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

MGMT-19287: fix grid in host discovery alignment #2875

merged 3 commits into from
Mar 26, 2025

Conversation

ElayAharoni
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2025 •
edited by openshift-ci bot
Loading

@ElayAharoni: This pull request references MGMT-19287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-19287

added flex to the cells:

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from batzionb and celdrake March 24, 2025 16:30
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 24, 2025
rawagner
rawagner requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the Flex container for the success case too

@ElayAharoni
fix grid in host discovery alignment
2fd5185 
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni force-pushed the grid-in-host-discovery-not-aligned-well branch from 634abf7 to 2fd5185 Compare March 25, 2025 08:03
@ElayAharoni ElayAharoni requested a review from rawagner March 25, 2025 09:54
@rawagner
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@rawagner
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ae77f39 into openshift-assisted:master Mar 26, 2025
10 checks passed
@ammont82 ammont82 added this to the v2.39 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner approved these changes

@batzionb batzionb Awaiting requested review from batzionb

@celdrake celdrake Awaiting requested review from celdrake

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v2.39
Development

Successfully merging this pull request may close these issues.
4 participants
@ElayAharoni @openshift-ci-robot @rawagner @ammont82