Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-20217: Assisted Operators Review #2882

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Mar 27, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025

@ElayAharoni: This pull request references MGMT-20217 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-20217

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from celdrake and jgyselov March 27, 2025 09:24
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@ElayAharoni ElayAharoni requested a review from ammont82 March 27, 2025 09:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025

@ElayAharoni: This pull request references MGMT-20217 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-20217

image

image

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nirfarkas
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Mar 27, 2025

@nirfarkas: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ElayAharoni ElayAharoni force-pushed the Assisted-Operators-Review branch from 81391ac to 606acdd Compare March 27, 2025 09:52
@ElayAharoni ElayAharoni force-pushed the Assisted-Operators-Review branch 13 times, most recently from 437b4c9 to 10c1219 Compare March 27, 2025 14:35
@ElayAharoni ElayAharoni requested a review from jgyselov March 27, 2025 14:44
@ammont82
Copy link
Member

ammont82 commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
Copy link

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, ElayAharoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2025
Signed-off-by: Elay Aharoni <elayaha@gmail.com>
@ElayAharoni ElayAharoni force-pushed the Assisted-Operators-Review branch from 124ef53 to d001f80 Compare April 1, 2025 09:17
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@ammont82
Copy link
Member

ammont82 commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7335061 into openshift-assisted:master Apr 1, 2025
10 checks passed
@ammont82 ammont82 added this to the v2.39 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants