Skip to content

MGMT-20200: Add new operators to virtualization bundle #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Mar 30, 2025

This PR adds 5 new operators to the virtualization bundle:

  1. Node Healthcheck.
  2. Self Node Remediation.
  3. Fence Agents Remdiation.
  4. Node Miantenance.
  5. Kube Descheduler.

All these operators are enabled only when the bundle is selected.

image

image

@danmanor danmanor requested a review from ammont82 March 30, 2025 16:28
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2025

@danmanor: This pull request references MGMT-20200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR adds 5 new operators to the virtualization bundle:

  1. Node Healthcheck.
  2. Self Node Remediation.
  3. Fence Agents Remdiation.
  4. Node Miantenance.
  5. Kube Descheduler.

All these operators are enabled only when the bundle is selected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jgyselov and rawagner March 30, 2025 16:28
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2025

@danmanor: This pull request references MGMT-20200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR adds 5 new operators to the virtualization bundle:

  1. Node Healthcheck.
  2. Self Node Remediation.
  3. Fence Agents Remdiation.
  4. Node Miantenance.
  5. Kube Descheduler.

All these operators are enabled only when the bundle is selected.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2025

@danmanor: This pull request references MGMT-20200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR adds 5 new operators to the virtualization bundle:

  1. Node Healthcheck.
  2. Self Node Remediation.
  3. Fence Agents Remdiation.
  4. Node Miantenance.
  5. Kube Descheduler.

All these operators are enabled only when the bundle is selected.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor danmanor force-pushed the add-ops branch 2 times, most recently from 706d44e to 8b809d2 Compare March 30, 2025 16:47
@danmanor danmanor requested a review from rawagner April 1, 2025 07:39
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@danmanor: This pull request references MGMT-20200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR adds 5 new operators to the virtualization bundle:

  1. Node Healthcheck.
  2. Self Node Remediation.
  3. Fence Agents Remdiation.
  4. Node Miantenance.
  5. Kube Descheduler.

All these operators are enabled only when the bundle is selected.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor danmanor requested a review from ammont82 April 1, 2025 11:14
@rawagner
Copy link
Member

rawagner commented Apr 1, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2025
@danmanor
Copy link
Contributor Author

danmanor commented Apr 1, 2025

@rawagner is there anything blocking it for merge ? or is it waiting

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
Signed-off-by: Dan Manor <dmanor@redhat.com>
@ammont82
Copy link
Member

ammont82 commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
Copy link

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, danmanor, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 502b74d into openshift-assisted:master Apr 1, 2025
10 checks passed
@ammont82 ammont82 added this to the v2.39 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants