MGMT-15963: Upgrade dockefiles to use centos:stream9 and build with podman

The current Dockerfile builds in this project are broken due to recent deprecation centos images.

This PR aims to address that by upgrading the images we use.
Additionally the build system is made more consistent with the podman compliant build that we use for assisted.
The host podman is passed to skipper so that the container may use podman-remote to build the project.

Author: paul-maidment

Dockerfile.assisted-swarm

@@ -1,4 +1,4 @@
-FROM quay.io/centos/centos:stream8
+FROM quay.io/centos/centos:stream9
 
 ARG WORK_DIR=/data
 

Dockerfile.assisted-swarm-build

@@ -1,15 +1,26 @@
-FROM registry.ci.openshift.org/openshift/release:golang-1.17
-ENV GO111MODULE=on
-ENV GOFLAGS=""
+FROM registry.ci.openshift.org/openshift/release:golang-1.20 AS golang
+RUN chmod g+xw -R /usr/local/go
 
-COPY --from=quay.io/goswagger/swagger:v0.28.0 /usr/bin/swagger /usr/bin/goswagger
-COPY --from=quay.io/edge-infrastructure/swagger-codegen-cli:2.4.18 /opt/swagger-codegen-cli /opt/swagger-codegen-cli
+FROM quay.io/centos/centos:stream9
 
-USER 0
+ENV GOPATH=/go
+ENV GOROOT=/usr/local/go
+ENV VIRTUAL_ENV=/opt/venv
+# A directory in the path with write permission even for non-root users
+ENV TOOLS=/tools/
+ENV PATH="$VIRTUAL_ENV/bin:$GOROOT/bin:$GOPATH/bin:$TOOLS:$PATH"
 
-RUN curl -L https://github.com/stoplightio/spectral/releases/download/v5.9.1/spectral-linux -o /usr/local/bin/spectral && chmod +x /usr/local/bin/spectral
+RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b /usr/bin v1.53.2
+COPY --from=quay.io/goswagger/swagger:sha-5d0a00d /usr/bin/swagger /usr/bin/goswagger
 
-RUN yum install -y --setopt=skip_missing_names_on_install=False docker podman
-RUN mkdir build && chmod g+xw -R build/
+COPY --from=quay.io/edge-infrastructure/swagger-codegen-cli:2.4.18 /opt/swagger-codegen-cli /opt/swagger-codegen-cli
+COPY --from=golang /usr/bin/gotestsum /usr/bin/make /usr/bin/
+COPY --from=golang /usr/local/go /usr/local/go
+COPY --from=quay.io/openshift/origin-cli:latest /usr/bin/oc /usr/bin
+COPY --from=quay.io/operator-framework/upstream-opm-builder:v1.16.1 /bin/opm /bin
+COPY --from=registry.k8s.io/kustomize/kustomize:v4.3.0 /app/kustomize /usr/bin/
+COPY --from=quay.io/coreos/shellcheck-alpine:v0.5.0 /bin/shellcheck /usr/bin/shellcheck
 
-RUN chmod g+xw -R .
+COPY ./hack/setup_env.sh ./
+RUN ./setup_env.sh podman_remote && \
+    dnf clean all

Makefile

@@ -1,9 +1,6 @@
 ASSISTED_SWARM = build/assisted-swarm
-CONTAINER_COMMAND := $(or $(CONTAINER_COMMAND),docker)
+CONTAINER_COMMAND := podman-remote
 IMAGE := $(or $(IMAGE),quay.io/oamizur/assisted-swarm:latest)
-ifeq ($(CONTAINER_COMMAND), docker)
-	CONTAINER_COMMAND = $(shell docker -v | cut -f1 -d' ' | tr '[:upper:]' '[:lower:]')
-endif
 
 .PHONY: build-image generate clean
 

hack/setup_env.sh

@@ -0,0 +1,8 @@
+function podman_remote() {
+  curl --retry 5 --connect-timeout 30 -L https://github.com/containers/podman/releases/download/v4.1.1/podman-remote-static.tar.gz -o "podman-remote.tar.gz"
+  tar -zxvf podman-remote.tar.gz
+  mv podman-remote-static /usr/local/bin/podman-remote
+  rm -f podman-remote.tar.gz
+}
+
+"$@"

skipper.env

@@ -0,0 +1 @@
+IMAGE

skipper.yaml

@@ -6,8 +6,13 @@ volumes:
   - $HOME/.cache/go-build:/go/pkg/mod
   # Registry credentials
   - $HOME/.docker/:$HOME/.docker
+  # Podman socket for podman-remote
+  - $(podman info --format "{{.Host.RemoteSocket.Path}}" 2> /dev/null || echo "$XDG_RUNTIME_DIR/podman/podman.sock"):/run/podman/podman.sock
 
 containers:
   assisted-swarm-build: Dockerfile.assisted-swarm-build
+env_file:
+  - skipper.env
 env:
   GOCACHE: "/go/pkg/mod"
+  CONTAINER_HOST: unix://run/podman/podman.sock